Re: 2.3.42 alpha updates

From: Richard Henderson (rth@cygnus.com)
Date: Fri Feb 04 2000 - 14:56:09 EST


On Fri, Feb 04, 2000 at 08:42:15PM +0100, Manfred Spraul wrote:
> Many functions such as try_to_swap_out() call flush_tlb_xy() while they
> own a spinlock (eg. mm->page_table_lock).

Really? Would you show me the call path from the spin lock aquire
to try_to_swap_out? I don't see it.

I do see

 * NOTE! If it sleeps, it *must* return 1 to make sure we
 * don't continue with the swap-out. Otherwise we may be
 * using a process that no longer actually exists (it might
 * have died while we slept).

attached to try_to_swap_out, so that's probably enough not to
call schedule, but I don't see any such spinlock held. Moreover,
the comment would seem to indicate it _is_ legal to sleep, so
long as you indicate that it happened.

r~

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Feb 07 2000 - 21:00:11 EST