James Simmons wrote:
>
> Howdy!!!
>
> With the latest kernel you can have the matrox driver compiled with i2c
> support without having i2c support in the kernel. This causes the compile
> to fail. This patch fixes this. It test to see if you have i2c support
> selected.
IMHO I2C is such a low-level bus, the user might not know to select it
until it is too late.
Why not instead have
define_tristate CONFIG_I2C $CONFIG_FB_MATROX
> Codito, ergo sum - "I code, therefore I am"
> James Simmons (o_
> fbdev/gfx developer (o_ (o_ //\
> http://www.linux-fbdev.org (/)_ (/)_ V_/_
> http://linuxgfx.sourceforge.net
>
> --- linux-2.3.48-3/drivers/video/Config.in Sat Feb 26 10:21:18 2000
> +++ linux/drivers/video/Config.in Sun Feb 27 11:08:41 2000
> @@ -105,10 +105,12 @@
> bool ' Millennium I/II support' CONFIG_FB_MATROX_MILLENIUM
> bool ' Mystique support' CONFIG_FB_MATROX_MYSTIQUE
> bool ' G100/G200/G400 support' CONFIG_FB_MATROX_G100
> - dep_tristate ' Matrox I2C support' CONFIG_FB_MATROX_I2C $CONFIG_FB_MATROX $CONFIG_I2C_ALGOBIT
> - if [ "$CONFIG_FB_MATROX_G100" = "y" ]; then
> - dep_tristate ' G400 second head support' CONFIG_FB_MATROX_MAVEN $CONFIG_FB_MATROX_I2C
> - fi
> + if [ "$CONFIG_I2C" != "n" ]; then
> + dep_tristate ' Matrox I2C support' CONFIG_FB_MATROX_I2C $CONFIG_FB_MATROX $CONFIG_I2C_ALGOBIT
> + if [ "$CONFIG_FB_MATROX_G100" = "y" ]; then
> + dep_tristate ' G400 second head support' CONFIG_FB_MATROX_MAVEN $CONFIG_FB_MATROX_I2C
> + fi
> + fi
> bool ' Multihead support' CONFIG_FB_MATROX_MULTIHEAD
> fi
> tristate ' ATI Mach64 display support (EXPERIMENTAL)' CONFIG_FB_ATY
-- Jeff Garzik | "Are you the police?" Building 1024 | MandrakeSoft, Inc. | "No ma'am. We're musicians."- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Feb 29 2000 - 21:00:17 EST