Re: [linux-usb] Re: Irq context wrong for USB ACM serial driver calling PPP?

From: Vojtech Pavlik (vojtech@suse.cz)
Date: Mon Mar 06 2000 - 15:35:40 EST


On Mon, Mar 06, 2000 at 06:50:42PM +0100, Jamie Lokier wrote:
> Vojtech Pavlik wrote:
> > Well, the USB ACM driver does just tty_flip_buffer_push() from an
> > interrupt, which I think is normal even for other drivers? Well, if not,
> > I can change it ...
>
> serial.c does that.
>
> > Hmm, it also calls a tty->ldisc.write_wakeup from an interrupt. Might
> > this be the cause?
>
> Yes that's what I was thinking. ppp_async.c does some complicated
> looking stuff in write_wakeup... including a kfree_skb(). That would
> explain the message. That could just be changed to kfree_skb_any().
>
> I really don't know if the rest of ppp_async_wakeup is irq safe, but it
> does like it _might_ be.

Ok, could you check if this patch to acm.c fixes the problem for you?

-- 
Vojtech Pavlik
SuSE Labs


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:20 EST