Re: [patch] 2.3.99-pre4-3: arc_rimi_setup

From: Martin Mares (mj@suse.cz)
Date: Mon Apr 03 2000 - 11:26:19 EST

Hello Tim!

> Here is a patch to make arc_rimi_setup return 0 on error.

   These two patches are incorrect: the test is not an error test,
it's a test for the user explicitly disabling the driver.

> Index: drivers/net/arcnet/arc-rimi.c
> ===================================================================
> RCS file: /usr/local/src/cvsroot/linux/drivers/net/arcnet/arc-rimi.c,v
> retrieving revision 1.1.1.2
> diff -u -r1.1.1.2 arc-rimi.c
> --- drivers/net/arcnet/arc-rimi.c 2000/02/14 10:00:06 1.1.1.2
> +++ drivers/net/arcnet/arc-rimi.c 2000/04/03 15:36:37
> @@ -343,7 +343,7 @@
>
> s = get_options(s, 8, ints);
> if (!ints[0])
> - return 1;
> + return 0;
> dev = alloc_bootmem(sizeof(struct net_device) + 10);
> memset(dev, 0, sizeof(struct net_device) + 10);
> dev->name = (char *) (dev + 1);
>
> Index: drivers/net/arcnet/com90io.c
> ===================================================================
> RCS file: /usr/local/src/cvsroot/linux/drivers/net/arcnet/com90io.c,v
> retrieving revision 1.1.1.2
> diff -u -r1.1.1.2 com90io.c
> --- drivers/net/arcnet/com90io.c 2000/02/14 10:00:06 1.1.1.2
> +++ drivers/net/arcnet/com90io.c 2000/04/03 15:47:20
> @@ -426,7 +426,7 @@
>
> s = get_options(s, 4, ints);
> if (!ints[0])
> - return 1;
> + return 0;
> dev = alloc_bootmem(sizeof(struct net_device) + 10);
> memset(dev, 0, sizeof(struct net_device) + 10);
> dev->name = (char *) (dev + 1);

                                Have a nice fortnight 

-- 
Martin `MJ' Mares <mj@ucw.cz> <mj@suse.cz> http://atrey.karlin.mff.cuni.cz/~mj/
"Windows Error: 002 - No error yet ..."

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Apr 07 2000 - 21:00:10 EST