[PATCH] small dqout.c clean up.

• Next message: Dave Jones: "[PATCH] fixes for kernel with no procfs."
• Previous message: Jeremy Fitzhardinge: "Re: Music CD's"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

The following diff removes a compiler warning (ambiguous else), and also
makes the code more readable. This diff has not been tested, can someone
give me feedback that I attributed the else to the correct if statement?

regards,

Dave.

diff -urN linux-2.3.99pre4/fs/dquot.c linux-2.3.99pre4-dj/fs/dquot.c
--- linux-2.3.99pre4/fs/dquot.c Mon Apr 3 19:08:58 2000
+++ linux-2.3.99pre4-dj/fs/dquot.c Mon Apr 3 21:36:36 2000
@@ -716,15 +716,16 @@
         }
         inode->i_flags &= ~S_QUOTA;
 put_it:
- if (dquot != NODQUOT)
+ if (dquot != NODQUOT) {
                 if (dqput_blocks(dquot)) {
                         if (dquot->dq_count != 1)
                                 printk(KERN_WARNING "VFS: Adding dquot with dq_count %d to dispose list.\n", dquot->dq_count);
                         list_add(&dquot->dq_free, tofree_head); /* As dquot must have currently users it can't be on the free list... */
                         return 1;
- }
- else
+ } else {
                         dqput(dquot); /* We have guaranteed we won't block */
+ }
+ }
         return 0;
 }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Dave Jones: "[PATCH] fixes for kernel with no procfs."
• Previous message: Jeremy Fitzhardinge: "Re: Music CD's"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Apr 07 2000 - 21:00:10 EST