Re: Meaning of CONFIG_* and [PATCH] 3c509 and modular ISAPnP

From: Andrzej Krzysztofowicz (ankry@pg.gda.pl)
Date: Fri Apr 07 2000 - 12:07:58 EST

Next message: david parsons: "Re: Suggested dual human/binary interface for proc/devfs"
Previous message: Peter Zaitsev: "Re: Some more info about CONNECT/ACCEPT problem."
In reply to: Petr Vandrovec: "Meaning of CONFIG_* and [PATCH] 3c509 and modular ISAPnP"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>
> Hi Linus, hi others,
> could you apply this patch to 3c509 driver in 2.3.99-pre4-pre4?
> Without that modular 3c509 does not understand modular ISAPNP.
> So please apply this, isapnp.h defines __ISAPNP__ just if
> CONFIG_ISAPNP || (CONFIG_ISAPNP_MODULE && MODULE).

IMHO, using

#if defined(CONFIG_ISAPNP) || defined(CONFIG_ISAPNP_MODULE)

is much better, as your patch breaks dependencies.

>
> -#ifdef CONFIG_ISAPNP
> +#ifdef __ISAPNP__

--
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

Next message: david parsons: "Re: Suggested dual human/binary interface for proc/devfs"
Previous message: Peter Zaitsev: "Re: Some more info about CONNECT/ACCEPT problem."
In reply to: Petr Vandrovec: "Meaning of CONFIG_* and [PATCH] 3c509 and modular ISAPnP"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Apr 07 2000 - 21:00:18 EST