Andrew Morton wrote:
> Well, at present this driver supports EISA, PCI and cardbus. But it
> _used_ to have a couple of #ifdef CARDBUS conditionals in it. I have
> removed these, deferring the decision to runtime.
>
> If there is a future need to employ #ifdef CARDBUS then 3c59x.o and
> 3c575_cb.o will be different, even though the source is the same. I
> don't think this option should be discarded.
Personally I think ifdefs are ugly and make for buggier code, since not
all code paths are built and tested at all times...
So, I would phrase the question like: Is supporting CardBus so
cumbersome to the driver that ifdefs absolutely must be employed?
Jeff
-- Jeff Garzik | Nothing cures insomnia like the Building 1024 | realization that it's time to get up. MandrakeSoft, Inc. | -- random fortune- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Apr 15 2000 - 21:00:19 EST