Re: PATCH for drivers/net/pcnet32.c to use pci_alloc_consistent

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Tue May 02 2000 - 12:34:36 EST

Jeff Garzik wrote:
> * two errors in the following code. (1) "if (0)", (2) you don't need to
> print out a message, the PCI subsystem does that for you

cut-n-paste doesn't work without the paste :) here is the code section
to which I am referring

+ if ((err = pci_enable_device(pdev)) < 0) {
+ printk(KERN_ERR "pcnet32.c: failed to enable device --
err=%d\n", err);
+ if (0) return err;
+
} 

-- 
Jeff Garzik              | Nothing cures insomnia like the
Building 1024            | realization that it's time to get up.
MandrakeSoft, Inc.       |        -- random fortune

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:10 EST