Re: initdata changes in 2.3.99-pre9-pre1 (was Re: bug in emu10k1 under...)

• Next message: f5ibh: "VFS: Busy inodes after unmount..."
• Previous message: Lee Chin: "Re: sock_recvmsg in Kernel hangs for 10 seconds"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Russell King wrote:
>
> I'm not the culpret, but I wonder if you've got the wrong end of the stick.
>
> Jeff Garzik writes:
> > __devinitdata should NOT be used unless you are certain the driver is a
> > hotplug driver. Otherwise __initdata should be used. Similar rules for
> > __init and __devinit.
> >
> > The patch in 2.3.99-pre9-pre1 blindly moves everything to __devinitdata,
> > which causes memory wastage in non-hotplug kernels (ie. the majority of
> > the kernels out there).
>
> Are you *sure* about this?
[...]
> Therefore, there is no difference to "non-hotplug" kernels. The only
> difference is to proper hotplug kernels.

I plead -ENOCAFFEINE :)

The first paragraph is correct -- don't use __devinitdata unless the
hardware is hotplug -- but you are correct, the second paragraph should
state that memory is wasted only on proper hotplug kernels, the minority
of the kernels out there.

Regards,

        Jeff

-- 
Jeff Garzik              | Liberty is always dangerous, but
Building 1024            | it is the safest thing we have.
MandrakeSoft, Inc.       |      -- Harry Emerson Fosdick
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: f5ibh: "VFS: Busy inodes after unmount..."
• Previous message: Lee Chin: "Re: sock_recvmsg in Kernel hangs for 10 seconds"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:23 EST