Eventually the semaphore will be replaced by the
spinlock (at least most ocurrences) but I need more than
a couple of hours looking at the code for the first time
to do it right...
Rui Sousa
On Tue, 23 May 2000, Gerd Knorr wrote:
>
> > - save_flags(flags);
> > - cli();
> > + spin_lock_irqsave(&btv->s_lock, flags);
>
> > out_unlock:
> > up(&btv->lock);
> > + MOD_DEC_USE_COUNT;
>
> > +++ linux-2.3.new/drivers/char/bttv.h Tue May 23 01:59:32 2000
> > @@ -143,6 +143,8 @@
> >
> > int tuner_type;
> > int channel;
> > +
> > + spinlock_t s_lock;
>
> ahm, this looks wrong to my eyes too: using two different locking
> mechanisms in parallel (the existing semaphore btv->lock vs. new
> spinlock btv->s_lock).
>
> Gerd
>
> --
> Protecting the children is a good way to get a lot of adults who cant
> stand up for themselves. -- seen in some sig on /.
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:11 EST