Re: [PATCH] ATI Mach64 Framebuffer bug

From: James Simmons (jsimmons@acsu.buffalo.edu)
Date: Sun May 28 2000 - 08:58:55 EST


> diff -ur linux-2.4.0-test1/drivers/video/atyfb.c linux/drivers/video/atyfb.c
> --- linux-2.4.0-test1/drivers/video/atyfb.c Tue Apr 11 10:00:08 2000
> +++ linux/drivers/video/atyfb.c Sat May 27 17:46:43 2000
> @@ -2931,7 +2931,7 @@
> if ((err = fb_alloc_cmap(&disp->cmap, size, 0)))
> return err;
> }

       This works when you have several card in your system. The check
       !info->display_fg is not needed since the fbcon layer always
       initializes this. The second part compares if the current active VT
       for the CURRENT video card is equal to con. Each seperate video
       card will have it own display_fg which points to the active VT this
       card is on. This is the hack to have multi display working. I don't
       consider it multihead since I consider multihead as having seperate
       keyboards and seperate video cards acting as individual consoles.

       Note:
        
          Fbcon should be using info->display_fg instead of fg_console
          for the code inside fbcon.c. Same for the fbdev drivers. This is
          a big BUG!!!!! Also the above doesn't help much if the VT switching
          function doesn't keep info->display_fg equal to the active VT. I
          think this could be made generic so we could place it in
          fbcon_switch.

> - if (!info->display_fg || con == info->display_fg->vc_num)

       This works for single card systems. Maybe it works in multihead
       setup? Don't know but it feels fishy to me. I feel comfortable
       with using info->display_fg more. I have to look at the code carefully
       to figure it out. I know fbcon.c has problems with this :(
               
> + if (con == currcon) /* current console? */
> return fb_set_cmap(cmap, kspc, atyfb_setcolreg, info);
> else
> fb_copy_cmap(cmap, &disp->cmap, kspc ? 0 : 1);

Q: Why did they deprecate a.out support in linux?
A: Because a nasty coff is bad for your elf.

James Simmons [jsimmons@linux-fbdev.org] ____/|
fbdev/console/gfx developer \ o.O|
http://www.linux-fbdev.org =(_)=
http://linuxgfx.sourceforge.net U
http://linuxconsole.sourceforge.net

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:19 EST