On 29 May 00 at 13:58, Yuri Per wrote:
> The check "con == currcon" is the same as in ALL other framebuffer drivers.
> If this is wrong, all drivers should be changes, not only the ATI one.
It depends... If driver can have more than one instance of hardware driven
by same module, then check is wrong - you must have per-fb_info curcon
(like matroxfb has). If you have different drivers, it is OK, as each
driver has its own currcon (of course, you must mark 'currcon' static, not
exported, otherwise it will not work as expected).
> As I understand "currcon" variable is not compatible with multi-display
> mode,
> so it shold be eliminated from all drivers. I don't think that such chanegs
> are possible before kernel 2.5.
Any driver (in kernel tree) should not have global variables, unless they
are used for load-time defaults or for linked list (or something...) of
driver instances... - or if driver can drive only one instance of hardware,
but we should eliminate such drivers unless it is really once per computer
(maybe ACPI is only once per computer, but I'm not sure...)
Petr Vandrovec
vandrove@vc.cvut.cz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:20 EST