On Mon, 29 May 2000, Alexander Viro wrote:
> > Hmmm... Could you guys look at the dcache-threading patch? It's about the
> > last major change to fs-visible parts of VFS and it promises to make for
> > _much_ nicer threading. Basically, lookup-related code is SMP-safe now,
> > big lock is taken only before calling the fs methods and dropped
> > immediately after the return.
> >
> > (patch had been announced several days ago, I'm currently rediffing it to
> > the latest Alan's tree; old one on ftp.math.psu.edu/pub/viro/dcache-ac2-A
>
Ok, I found dcache-ac4-A. I don't see anything that should break us, and
it is holding up well so far in testing.
Inside reiserfs_read_super, we have a failure path that calls
dput(s->s_root). This looks ok to me, but please let me know if I'm
missing something...
Looks like a spin_unlock is missing during unmount, this patch fixed it
for me (against 2.4.0-test1-ac4+dcache-ac4-A)
-chris
--- /usr/src/diff/linux/fs/super.c Mon May 29 10:53:26 2000
+++ linux/fs/super.c Mon May 29 10:46:58 2000
@@ -1018,6 +1018,7 @@
mntput(mnt);
return -EBUSY;
}
+ spin_unlock(&dcache_lock);
/* OK, that's the point of no return */
mntput(mnt);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:21 EST