RE: [PATCH] Fix ambassador atm driver with recent gcc

• Next message: Thomas Graichen: "Re: Does /var/shm still need to be mounted?"
• Previous message: Anton Altaparmakov: "Re: How stable is NTFS write?"
• Maybe in reply to: Jakub Jelinek: "[PATCH] Fix ambassador atm driver with recent gcc"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Jacub Jelinek wrote:

> Hi!

> ambassador fails to build with gcc 2.96 for two reasons:
> 1) illegal use of string concatenation in #include - the new C
preprocessor
> does not allow this nor does it allow any non-GNU preprocessor - you can
> pass only one string to #include.
> The hunk below was tested both with egcs 1.1.2 and gcc 2.96.
> 2) the static const amb_mem * const mem = 0; trick does not work either,
but
> it is a really good candidate for offsetof IMHO which is exactly what the
> driver is trying to do.

Thanks for this. Yes, offsetof is just the right thing to use, I'm not sure
anymore who I got the (foo *) 0 idea from. I will check through your changes
and probably get rid of AMB_MMIO and AMB_NEW_MICROCODE (only ever used by me
during testing) while I'm at it.

Giuliano.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Thomas Graichen: "Re: Does /var/shm still need to be mounted?"
• Previous message: Anton Altaparmakov: "Re: How stable is NTFS write?"
• Maybe in reply to: Jakub Jelinek: "[PATCH] Fix ambassador atm driver with recent gcc"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:23 EST