Heh :) No big deal man. This design option is really neat, in my
opinion.. Its new, so its bound to have a FEW implementation issues to
start. :)
As another suggestion...
You can allow a person to mount the same fs in unlimited places. thats
just fine.
But do *NOT* allow a mount on top of an already mounted filesystem.
I.E.
mount /dev/hda1 /mnt
mount /dev/hda1 /mnt
should *NOT* work.
whereas:
mount /dev/hda1 /mnt
mount /dev/hda1 /mnt2
SHOULD work.
You also should, like Alan said earlier, be requiring a flag to be passed
in, to support the multimount option...(So someone using it expecting the
"old" behavior, won't trip over themselves...)
Just my 2 cents. take my suggestions for whatever their worth. :)
Chad
> Oh, fsck... Yes, I see what happens - sorry, my fault. Stupid bug in
> add_vfsmnt() - thanks for catching it. Quick fix: in add_vfsmnt()
> replace
> if (parent)
> list_add(&mnt->mnt_child, &parent->mnt_mounts);
> else
> INIT_LIST_HEAD(&mnt->mnt_child);
> INIT_LIST_HEAD(&mnt->mnt_mounts);
> list_add(&mnt->mnt_instances, &sb->s_mounts);
> list_add(&mnt->mnt_clash, &mountpoint->d_vfsmnt);
> list_add(&mnt->mnt_list, vfsmntlist.prev);
> with
> if (parent) {
> list_add(&mnt->mnt_child, &parent->mnt_mounts);
> list_add(&mnt->mnt_clash, &mountpoint->d_vfsmnt);
> } else {
> INIT_LIST_HEAD(&mnt->mnt_child);
> INIT_LIST_HEAD(&mnt->mnt_clash);
> }
> INIT_LIST_HEAD(&mnt->mnt_mounts);
> list_add(&mnt->mnt_instances, &sb->s_mounts);
> list_add(&mnt->mnt_list, vfsmntlist.prev);
>
> and ditto for move_vfsmnt(). Sorry about that...
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:24 EST