Re: PATCH: amd7409.c

From: Juan J. Quintela (quintela@fi.udc.es)
Date: Wed May 31 2000 - 12:09:38 EST


>>>>> "bartlomiej" == Bartlomiej Zolnierkiewicz <dake@staszic.waw.pl> writes:

bartlomiej> Hi
bartlomiej> following patch:

bartlomiej> * adds support for single-word DMA modes for chipset revisions >= C4
bartlomiej> * prints nice :) info when chipset revision is < C4
bartlomiej> * adds info about available AMD's datasheets
bartlomiej> * moves 'pio_timing |= (0x03 << drive->dn);' outside switch(speed) {}
bartlomiej> in function amd7409_tune_chipset ()
bartlomiej> * removes two unused externs

bartlomiej> This patch is against kernel 2.4.0-test1-ac4 but also applies cleanly to
bartlomiej> vanilla 2.4.0-test1 and ac1/ac2/ac5.

Hi
        I just applied this patch against ac7 (hand apply of the first
        chunk, but easy to solve).

I have found that my system boots with this patch, but It only gets
ATA33 mode (amd7409 chip) with my disk (Seagate Barracuda
hda: ST310220A, ATA DISK drive). Without the patch, if I use the overaid option
(ide0=ata66) I get ~26MB/s (hdparm -t test). Without overide I get
around 16MB/s. With this patch I get 16MB/s, it doesn't matter if I
use ide0=ata66 or not.

Later, Juan.

PD. I don't know *where* the patch got mangled, but for me it appears
1 in several places

+byte 1word_dma_ok = 0;
      ^
      | like this one
the changes was consistent in all the patch, then easy to fix.

-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:28 EST