Re: Linux 2.4.0test1-ac10

From: Andreas Bombe (andreas.bombe@munich.netsurf.de)
Date: Tue Jun 06 2000 - 15:34:32 EST


On Tue, Jun 06, 2000 at 06:50:09PM +0100, Alan Cox wrote:
[...]
> 2.4.0-test1-ac9
[...]
> o pci_enable for lynx iee1394 (Jeff Garzik)

This is an older independent patch by Jeff, my ieee1394 updates I sent
you for ac7 already include an pci_enable_device call.

To quote the ac10 patch:

@@ -1241,11 +1227,19 @@
                 return 1;
         }
 
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,3,0)
+ if (pci_enable_device(dev))
+ return 1;
+#endif
+
         lynx = &cards[num_of_cards++];
 
         lynx->id = num_of_cards-1;
         lynx->dev = dev;
 
+ if (pci_enable_device(dev)) {
+ FAIL("failed to enable PCILynx hardware %d", lynx->id);
+ }
         pci_set_master(dev);
 
         if (!request_irq(dev->irq, lynx_irq_handler, SA_SHIRQ,

First is Jeff's, please delete it again. Sorry that I don't have a
patch handy, but that would be overkill I guess :-) It's
drivers/ieee1394/pcilynx.c around (as the patch quote says) line 1230.

Thanks.

-- 
 Andreas E. Bombe <andreas.bombe@munich.netsurf.de>    DSA key 0x04880A44
http://home.pages.de/~andreas.bombe/    http://linux1394.sourceforge.net/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jun 07 2000 - 21:00:26 EST