Re: Result of compiling with `-W'

From: Andreas Schwab (schwab@suse.de)
Date: Thu Jul 13 2000 - 12:06:46 EST

Next message: Linus Torvalds: "Re: [Announce] BKL shifting into drivers and filesystems - beware"
Previous message: H. Peter Anvin: "Re: IBM Rapid Access Keyboard"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Andrew Morton <andrewm@uow.edu.au> writes:

|> --- linux-2.4.0-test4-pre6/drivers/sound/pss.c Wed Mar 8 08:40:24 2000
|> +++ linux-akpm/drivers/sound/pss.c Thu Jul 13 22:36:36 2000
|> @@ -233,7 +233,7 @@
|> unsigned long i, limit = jiffies + HZ/10;
|>
|> outw(0x2000, REG(PSS_CONTROL));
|> - for (i = 0; i < 32768 && (limit-jiffies >= 0); i++)
|> + for (i = 0; i < 32768 && ((signed)(limit-jiffies) >= 0); i++)
|> inw(REG(PSS_CONTROL));
|> outw(0x0000, REG(PSS_CONTROL));
|> return 1;
|> @@ -332,11 +332,11 @@
|> outw(0, REG(PSS_DATA));
|>
|> limit = jiffies + HZ/10;
|> - for (i = 0; i < 32768 && (limit - jiffies >= 0); i++)
|> + for (i = 0; i < 32768 && ((signed)(limit - jiffies) >= 0); i++)
|> val = inw(REG(PSS_STATUS));
|>
|> limit = jiffies + HZ/10;
|> - for (i = 0; i < 32768 && (limit-jiffies >= 0); i++)
|> + for (i = 0; i < 32768 && ((signed)(limit-jiffies) >= 0); i++)
|> {
|> val = inw(REG(PSS_STATUS));
|> if (val & 0x4000)

This should actually use the time_before/time_after macros.

Andreas.

-- Andreas Schwab "And now for something SuSE Labs completely different." Andreas.Schwab@suse.de SuSE GmbH, Schanz�ckerstr. 10, D-90443 N�rnberg

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/

Next message: Linus Torvalds: "Re: [Announce] BKL shifting into drivers and filesystems - beware"
Previous message: H. Peter Anvin: "Re: IBM Rapid Access Keyboard"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Jul 15 2000 - 21:00:17 EST