Re: 2.4.0-test5-pre4 compile warning fixes

From: Linus Torvalds (torvalds@transmeta.com)
Date: Tue Jul 25 2000 - 16:35:52 EST


On Tue, 25 Jul 2000, Frank van Maarseveen wrote:

> if (offset % ssize) {
> - printk(KERN_WARNING "jffs_flash_erasable_size() given non-aligned offset %lx (erasesize %lx)\n", offset, ssize);
> + printk(KERN_WARNING "jffs_flash_erasable_size() given non-aligned offset %lx (erasesize %lx)\n", (u_long)offset, ssize);

Actually, I'd much rather just see

        %x, offset

because "u32" is a "int" or possibly in the future a "short". Linux
doesn't support any sub-32-bit computers, and despite the occasional
deranged people interested in retro-computing (ie Alan Cox) I doubt it
seriously will..

I dislike casts.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 31 2000 - 21:00:20 EST