Re: [PATCH] drivers/char/ppdev.c: returning copy_to_user result

From: Michael Elizabeth Chastain (mec@shout.net)
Date: Fri Aug 25 2000 - 09:41:37 EST

Next message: Arnaldo Carvalho de Melo: "Re: [PATCH] drivers/char/ppdev.c: returning copy_to_user result"
Previous message: Andries Brouwer: "Re: [FIX] Make deadlock detection work for file locking"
Maybe in reply to: Arnaldo Carvalho de Melo: "[PATCH] drivers/char/ppdev.c: returning copy_to_user result"
Next in thread: Arnaldo Carvalho de Melo: "Re: [PATCH] drivers/char/ppdev.c: returning copy_to_user result"
Reply: Arnaldo Carvalho de Melo: "Re: [PATCH] drivers/char/ppdev.c: returning copy_to_user result"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> Please take a look and consider applying. Feedback about why it would
> be wrong would be greatly appreciated.

I eyeballed this and it looks correct to me, except that the comment
at the top is slightly wrong.

On error, copy_from_user and copy_to_user do not return -EFAULT,
They return the positive number of bytes *not* copied due to address
space errors.

Michael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Arnaldo Carvalho de Melo: "Re: [PATCH] drivers/char/ppdev.c: returning copy_to_user result"
Previous message: Andries Brouwer: "Re: [FIX] Make deadlock detection work for file locking"
Maybe in reply to: Arnaldo Carvalho de Melo: "[PATCH] drivers/char/ppdev.c: returning copy_to_user result"
Next in thread: Arnaldo Carvalho de Melo: "Re: [PATCH] drivers/char/ppdev.c: returning copy_to_user result"
Reply: Arnaldo Carvalho de Melo: "Re: [PATCH] drivers/char/ppdev.c: returning copy_to_user result"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:16 EST