Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups

From: Philipp Rumpf (prumpf@parcelfarce.linux.theplanet.co.uk)
Date: Wed Aug 30 2000 - 14:02:06 EST

Next message: Alexander Viro: "Re: hfs support for blocksize != 512"
Previous message: Ville Herva: "Re: [PATCH] 2.2: /proc/config.gz"
In reply to: Linus Torvalds: "Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups"
Next in thread: Rogier Wolff: "Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Aug 30, 2000 at 10:04:12AM -0700, Linus Torvalds wrote:
> return copy_to_user(dst, src, size) ? -EFAULT : 0;
>
> is fine and quite readable. Fits on a simple line.

I agree so far. But when it's really

        if (put_user(..>)
                return -EFAULT;

        if (put_user(...))
                return -EFAULT;

        if (copy_to_user(...))
                return -EFAULT;

        if (copy_to_user(...))
                return -EFAULT;

return 0;

changing the last two statements to use ? : is just confusing (acme's changes
were somewhat less extreme), don't you agree ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Alexander Viro: "Re: hfs support for blocksize != 512"
Previous message: Ville Herva: "Re: [PATCH] 2.2: /proc/config.gz"
In reply to: Linus Torvalds: "Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups"
Next in thread: Rogier Wolff: "Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:26 EST