Re: [PATCH] mtrr: s/suser/capable/

From: Tigran Aivazian (tigran@veritas.com)
Date: Thu Aug 31 2000 - 02:51:29 EST

Next message: Tigran Aivazian: "Re: ramdisk driver source code"
Previous message: Andre Hedrick: "Re: 2.4.0-test5 problems with Promise ATA100"
In reply to: Arnaldo Carvalho de Melo: "[PATCH] mtrr: s/suser/capable/"
Next in thread: Matthew Kirkwood: "Re: [PATCH] mtrr: s/suser/capable/"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 30 Aug 2000, Arnaldo Carvalho de Melo wrote:
> - if ( !suser () ) return -EPERM;
> + if ( !capable(CAP_SYS_ADMIN) ) return -EPERM;

no, it should be CAP_SYS_RAWIO. I thought that is the convention for
accessing chipset-specific io features. E.g. see
arch/i386/kernel/microcode.c.

Regards,
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Tigran Aivazian: "Re: ramdisk driver source code"
Previous message: Andre Hedrick: "Re: 2.4.0-test5 problems with Promise ATA100"
In reply to: Arnaldo Carvalho de Melo: "[PATCH] mtrr: s/suser/capable/"
Next in thread: Matthew Kirkwood: "Re: [PATCH] mtrr: s/suser/capable/"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:26 EST