Re: [PATCH] mtrr: s/suser/capable/

From: Andi Kleen (ak@suse.de)
Date: Thu Aug 31 2000 - 06:15:02 EST

Next message: Andi Kleen: "Re: [PATCH] mtrr: s/suser/capable/"
Previous message: Arjan van de Ven: "Re: [PATCH] 2.2: /proc/config.gz"
In reply to: Matthew Kirkwood: "Re: [PATCH] mtrr: s/suser/capable/"
Next in thread: Alan Cox: "Re: [PATCH] mtrr: s/suser/capable/"
Reply: Alan Cox: "Re: [PATCH] mtrr: s/suser/capable/"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Aug 31, 2000 at 11:27:17AM +0100, Matthew Kirkwood wrote:
> > - if ( !suser () ) return -EPERM;
> > + if ( !capable(CAP_SYS_ADMIN) ) return -EPERM;
>
> Please think further about these random changes. CAP_SYS_ADMIN
> is already bloated with useless junk and these aren't helping
> the situation.
>
> These cases in mtrr.c are clearly CAP_SYS_RAWIO.

Clearly? How do MTRR changes relate to rawio ?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Andi Kleen: "Re: [PATCH] mtrr: s/suser/capable/"
Previous message: Arjan van de Ven: "Re: [PATCH] 2.2: /proc/config.gz"
In reply to: Matthew Kirkwood: "Re: [PATCH] mtrr: s/suser/capable/"
Next in thread: Alan Cox: "Re: [PATCH] mtrr: s/suser/capable/"
Reply: Alan Cox: "Re: [PATCH] mtrr: s/suser/capable/"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:27 EST