Re: [PATCH] alignment issue with ipchains

From: David S. Miller (davem@redhat.com)
Date: Fri Sep 08 2000 - 23:07:23 EST


   From: NIIBE Yutaka <gniibe@chroot.org>
   Date: Sat, 09 Sep 2000 12:18:28 +0900

   I'd like to explain my point clearly. My point is that accessing
   with get_user as int is questionable. In my case, it's string. I
   don't think all the string argment to the kernel should be aligned.

Thank you for the explanation.

I agree with your logic, but not with the fix you sent here before.

I would much rather see a test for the socket option cases that use
the "val", and in those cases do the get_user calls. Ie. something
like:

        if (optname == X || optname == Y || optname == Z || ...) {
                if(optlen>=sizeof(int)) {
                        if(get_user(val, (int *) optval))
   ...
        }

Could you send me a patch which fixes the problem in this way?

Thank you.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Sep 15 2000 - 21:00:11 EST