Re: NLS handling in Filesystem code

From: Urban Widmark (urban@svenskatest.se)
Date: Mon Sep 11 2000 - 12:30:43 EST


On Mon, 11 Sep 2000 tytso@mit.edu wrote:

> ISOFS ignores CONFIG_NLS_DEFAULT, and hardcodes the use of iso8859-1 as
> the default. Is this the correct behaviour?

I don't think so. 2.2 uses CONFIG_NLS_DEFAULT for 'iocharset'. Untested,
obvious patch for 2.4.0-test8 below to do the same as 2.2.

/Urban

--- linux-2.4.0-test8-orig/fs/isofs/inode.c Sat Aug 12 21:04:15 2000
+++ linux/fs/isofs/inode.c Mon Sep 11 19:17:13 2000
@@ -737,7 +737,7 @@
 
 #ifdef CONFIG_JOLIET
         if (joliet_level && opt.utf8 == 0) {
- char * p = opt.iocharset ? opt.iocharset : "iso8859-1";
+ char * p = opt.iocharset ? opt.iocharset : CONFIG_NLS_DEFAULT;
                 s->u.isofs_sb.s_nls_iocharset = load_nls(p);
                 if (! s->u.isofs_sb.s_nls_iocharset) {
                         /* Fail only if explicit charset specified */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Sep 15 2000 - 21:00:15 EST