RE: usb-uhci forgets to destroy kmem entries

From: Dunlap, Randy (randy.dunlap@intel.com)
Date: Fri Sep 15 2000 - 15:14:34 EST

Next message: Gérard Roudier: "Re: New topic (PowerPC Linux PCI HELL)"
Previous message: Zygo Blaxell: "Re: Proposal: Linux Kernel Patch Management System"
Maybe in reply to: Oleg Drokin: "usb-uhci forgets to destroy kmem entries"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> > +#ifdef DEBUG_SLAB
> > + if (retval < 0 ) {
> > + if(kmem_cache_destroy(uhci_desc_kmem))
>
> Why only #ifdef DEBUG_SLAB?
> AFAICS the driver should always destroy it's slab cache.
>
> Please cc, I'm not subscribed to linux-kernel.
(why not? :)
> --
> Manfred

This driver only uses slab caches when it's debugging.
DEBUG & SLAB go together.

~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Gérard Roudier: "Re: New topic (PowerPC Linux PCI HELL)"
Previous message: Zygo Blaxell: "Re: Proposal: Linux Kernel Patch Management System"
Maybe in reply to: Oleg Drokin: "usb-uhci forgets to destroy kmem entries"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Sep 15 2000 - 21:00:26 EST