Re: [PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

From: Andries Brouwer (aeb@veritas.com)
Date: Sat Sep 16 2000 - 09:24:55 EST


On Sat, Sep 16, 2000 at 03:26:33PM +0200, Alain Knaff wrote:

> The following patch (against 2.4.0-test8) restores ioctl functionality,
> which has been broken in 2.4.0-test6-pre7:

> + /* Allow ioctls if we have write-permissions even if read-only open.
> + * Needed so that programs such as fdrawcmd still can work on write
> + * protected disks */
> + if ((filp->f_mode & 2) || (permission(inode,2) == 0))
> + filp->f_mode |= FD_IOCTL_MODE_BIT;

Strange obscure kludges.
In util-linux 2.10o fdformat was fixed to work with 2.4.0test6.
In util-linux 2.10p (not yet released) setfdprm is fixed.
Only if there are programs that cannot be fixed we should
look at the kernel code again. But not go back to the old state.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 21:00:12 EST