Re: [PATCH] Fix sg in 2.4.0-test9-pre5 when builtin

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Thu Sep 21 2000 - 22:57:41 EST


Douglas Gilbert wrote:
> @@ -1298,18 +1302,20 @@
> }
>
> #ifdef MODULE
> -
> MODULE_PARM(def_reserved_size, "i");
> MODULE_PARM_DESC(def_reserved_size, "size of buffer reserved for each fd");
> +#endif /* MODULE */

MODULE_xxx typically doesn't need to be surrounded by ifdef MODULE.

Also note that proc_fs.h provides no-op inline replacements for the
!CONFIG_PROC_FS case. If you want to be really space conscious, you
still need the ifdef's in the code for the most part, but the no-ops
sometimes eliminate ifdefs if you look carefully.

        Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 21:00:26 EST