Re: [PATCH-2.2] Bonding Driver Enhancements + Security fix

From: willy tarreau (wtarreau@yahoo.fr)
Date: Tue Oct 03 2000 - 20:15:01 EST


Hello Thomas,

I've modified the slaves lists as you suggested to me.
The more I
tried to optimize the code, the more it looked like
2.4's, so it
seems the last one is already optimal. There's no
slave_queue
anymore, and the transmit path in bond_xmit_roundrobin
is far
faster.

I have also implemented a second xmit method :
active-backup :
instead of alternating on the slaves, it always emits
on the
same until its link fails, then it chooses the next
good one.
This way, there's only one active device at a time,
and backup
links are still monitored. This is very useful for
high availability
with 2 switches (one link to each one). Of course, I
tried to make
all the backup slaves deaf and for that I set their
NO_ARP flag, to
prevent the switches from seeing the interface at two
different
places. This may not be enough, but I'll try this
tomorrow on my 2
alteon. So for now, there are two xmit methods :
  - round robin (default, or mode=0)
  - active-backup (mode=1)

the mode argument should be given to modprobe when
loading the driver
as a module.

For the MII link monitoring, I've set the default to
disable checking,
to avoid any potential breaking of existing
installations. To activate
it, simply pass "miimon=XXX" where XXX is the check
interval in
milliseconds. At 10ms (one check at each jiffy), my
mouse becomes a
bit "jumpy", but 100ms is quite good.

I wanted to write some doc, but I will do tomorrow if
I can find some
spare time. It's too late for me to write something
correct and I must
get up in 3 hours. But I've included your
Configure.help patch.

So for this night, here's my patch against 2.2.17
(should be OK for
2.2.18pre15). I'd like several people to stress-test
it.

> See this:
http://docs.sun.com:80/ab2/coll.539.1/UGTRUNKING/@Ab2PageView/1311?Ab2Lang=C&Ab2Enc=iso-8859-1
>
> for information on the 4 possible trunking
> transmittors.

Thanks a lot, I will take a look.

Willy

___________________________________________________________
Do You Yahoo!? -- Pour dialoguer en direct avec vos amis,
Yahoo! Messenger : http://fr.messenger.yahoo.com


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Oct 07 2000 - 21:00:13 EST