Re: [PATCH] Make agpsupport work with modversions

From: David Woodhouse (dwmw2@infradead.org)
Date: Fri Oct 27 2000 - 08:25:48 EST


vojtech@suse.cz said:
> > But that module then depends on both of the others unless you keep
> > recompiling it

> Not really, see for example ns558.c and adi.c plus their third module
> gameport.c, all in drivers/char/joystick.

But in the case where there _aren't_ any functions which could usefully be
shared between the modules, you've got a whole extra gratuitous module
(What's that, 32KiB on some ARM boxen?) just to hold the registration
functions, which aren't needed if you just use get_module_symbol().

Provide generic code for registering such stuff and it might be acceptable.
Otherwise, get_module_symbol is better. There's no fundamental flaw with
get_module_symbol() - just one or two of the current usages of it.

--
dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 31 2000 - 21:00:21 EST