Re: USB Printer, in 2.4.0-test9

From: Randy Dunlap (randy.dunlap@intel.com)
Date: Fri Oct 27 2000 - 16:05:55 EST


Gerald, Benson-

USB in 2.4.0-test9 had several broken pieces in it.
Something like 2.4.0-test10-pre6 is much better IMO.
However, the USB printer driver in test10-pre6 still
needs the attached patch (already sent to Linus).

Please try test10-pre6 with this patch and let me know how it is.

Thanks,
~Randy

Gerald.Haese@gmx.de wrote:
>
> In article
> <linux.kernel.Pine.LNX.4.21.0010232241360.7434-100000@q.dyndns.org>,
> Benson Chow <blc@q.dyndns.org> wrote:
>
> > I get a bunch of form feeds too but it continues to print a few
> > characters fine and some that are totally wrong.
>
> The same problem here. I'am using a dual Pentium (GA586-DX) with 2 x 233
> MHz PentiumMMX and a PCI USB controller card with a VIA Chip. The
> printer is
> a DeskJet 970Cxi. Printing via USB is completely impossible.
>
> Gerald

--- linux/drivers/usb/printer.c.org Thu Oct 26 17:36:50 2000
+++ linux/drivers/usb/printer.c Thu Oct 26 17:09:53 2000
@@ -190,6 +190,8 @@
                 retval = retval > 1 ? -EIO : -ENOSPC;
                 goto out;
         }
+#else
+ retval = 0;
 #endif
 
         usblp->used = 1;
@@ -383,6 +385,7 @@
                 return -EFAULT;
 
         if ((usblp->readcount += count) == usblp->readurb.actual_length) {
+ usblp->readcount = 0;
                 usblp->readurb.dev = usblp->dev;
                 usb_submit_urb(&usblp->readurb);
         }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 31 2000 - 21:00:22 EST