Re: [PROPOSED PATCH] ATM refcount + firestream

From: Brian Gerst (bgerst@didntduck.org)
Date: Sat Oct 28 2000 - 08:55:21 EST


Philipp Rumpf wrote:
>
> On Sat, Oct 28, 2000 at 09:37:28AM -0400, Brian Gerst wrote:
> > Philipp Rumpf wrote:
> > > - you can't copy_(from|to)_user in the module exit function (which would
> > > be copies from/to rmmod anyway)
> >
> > Unfortunately, you need to be able to use copy_*_user() from the network
> > ioctls, and this is the center of the current issue.
>
> You misunderstood. The network ioctls aren't module_exit functions, so
> copy_*_user in them is fine.

Yes, but they can be called (and sleep) with module refcount == 0. This
is because the file descripter used to perform the ioctl isn't directly
associated with the network device, thereby not incrementing the
refcount on open.

-- 

Brian Gerst - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 31 2000 - 21:00:23 EST