Re: 2.4.0-test11-pre6 fails compile (dev.c)

From: Neil Brown (neilb@cse.unsw.edu.au)
Date: Thu Nov 16 2000 - 22:08:02 EST


On Thursday November 16, clem@clem.digital.net wrote:
> FYI:
>
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.0-test11/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=i686 -c -o dev.o dev.c
> dev.c: In function `run_sbin_hotplug':
> dev.c:2736: `hotplug_path' undeclared (first use in this function)
> dev.c:2736: (Each undeclared identifier is reported only once
> dev.c:2736: for each function it appears in.)
> make[3]: *** [dev.o] Error 1
> make[3]: Leaving directory `/sda3/usr/src/linux-2.4.0-test11/net/core'
> make[2]: *** [first_rule] Error 2
>
> --
> Pete Clements
> clem@clem.digital.net
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> Please read the FAQ at http://www.tux.org/lkml/

The following works for me.... and even looks right.

NeilBrown

--- ./init/main.c 2000/11/17 03:03:23 1.1
+++ ./init/main.c 2000/11/17 03:03:33
@@ -712,11 +712,13 @@
         init_pcmcia_ds(); /* Do this last */
 #endif
 
+#ifdef CONFIG_HOTPLUG
         /* do this after other 'do this last' stuff, because we want
          * to minimize spurious executions of /sbin/hotplug
          * during boot-up
          */
         net_notifier_init();
+#endif
 
         /* Mount the root filesystem.. */
         mount_root();
--- ./net/core/dev.c 2000/11/17 03:00:42 1.1
+++ ./net/core/dev.c 2000/11/17 03:03:53
@@ -2704,7 +2704,7 @@
         return 0;
 }
 
-
+#ifdef CONFIG_HOTPLUG
 /* Notify userspace when a netdevice event occurs,
  * by running '/sbin/hotplug net' with certain
  * environment variables set.
@@ -2765,3 +2765,5 @@
                 printk (KERN_WARNING "unable to register netdev notifier\n"
                         KERN_WARNING "/sbin/hotplug will not be run.\n");
 }
+
+#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:12 EST