Re: RFC: "SubmittingPatches" text

From: Rogier Wolff (R.E.Wolff@BitWizard.nl)
Date: Sat Nov 18 2000 - 05:24:39 EST

Next message: Alexander Viro: "[PATCH] ext2 largefile fixes + [f]truncate() error value fix"
Previous message: Keith Owens: "Re: passing arguments to module"
In reply to: Andries Brouwer: "Re: RFC: "SubmittingPatches" text"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Andries Brouwer wrote:
> On Fri, Nov 17, 2000 at 09:30:13AM +0100, Kai Germaschewski wrote:
>
> > One question comes to my mind: Are patches supposed to be applied with
> > patch -p0 or patch -p1?
>
> Suppose the kernel tree is in /kernpath, starting with /kernpath/linux.
> Linus' patches can be applied by (cd /kernpath; patch -p0 -s < patch)
^^^^ ALSO
> while Alan's patches only work if you do
> (cd /kernpath/linux; patch -p1 -s < ../patch)

For uniformity, I would recommend that everyone generates patches that
are "Linus-style", but that when applying, you treat them as "Alan-style".

Less chances for surprises.

Roger.

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
*       Common sense is the collection of                                *
******  prejudices acquired by age eighteen.   -- Albert Einstein ********
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Alexander Viro: "[PATCH] ext2 largefile fixes + [f]truncate() error value fix"
Previous message: Keith Owens: "Re: passing arguments to module"
In reply to: Andries Brouwer: "Re: RFC: "SubmittingPatches" text"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:15 EST