Re: [PATCH] ext2 largefile fixes + [f]truncate() error value fix

From: Alexander Viro (viro@math.psu.edu)
Date: Sat Nov 18 2000 - 16:55:23 EST


On Sat, 18 Nov 2000, Andrea Arcangeli wrote:

[2.2 variant]

RLIMIT_FSIZE stuff - vmtruncate().
size < 0 - caller.
size > ... - ext2_notify_change().
> if (size >> 33) {
                       ITYM 32
> struct super_block *sb = inode->i_sb;
> struct ext2_super_block *es = sb->u.ext2_sb.s_es;
> if (!(es->s_feature_ro_compat &
> cpu_to_le32(EXT2_FEATURE_RO_COMPAT_LARGE_FILE))){
> /* If this is the first large file
> * created, add a flag to the superblock */
> es->s_feature_ro_compat |=
> cpu_to_le32(EXT2_FEATURE_RO_COMPAT_LARGE_FILE);
> mark_buffer_dirty(sb->u.ext2_sb.s_sbh, 1);
> }
> }
 
... and that one - in ext2_update_inode().

> and btw the large file feature setting seems missing also from write(2) ext2
> in 2.4.x, confirm?

NAK. You do such write(), you end up doing ext2_update_inode().

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:16 EST