Re: [PATCH] Re: What is 2.4.0-test10: md1 has overlapping physical units with md2!

From: Ruth Ivimey-Cook (Ruth.Ivimey-Cook@arm.com)
Date: Mon Nov 20 2000 - 09:41:07 EST


Folks,

I won't try and invent a patch(1) for this, but might I suggest changing:

    md: serializing resync, md%d has shares one or more physical units with
md%d!\n

to

    md: serializing resync, md%d shares one or more disk drives with md%d.
Array performance may suffer.\n

Regards,

Ruth

At 12:49 AM 11/20/00, you wrote:
> the attached patch, modifies a warning message in md.c which seems to
> often cause confusion - the following email includes one example
> there-of (there have been others over the months).
> > What it means is that some partititions in md1 and md2 are on the same
> disk,
> > and that the md-code will not do the reconstruction of these arrays in
> > parallel [of course, for performance reasons].
> >
>
>
>--- ./drivers/md/md.c 2000/11/20 00:33:08 1.2
>+++ ./drivers/md/md.c 2000/11/20 00:44:19 1.3
>@@ -3279,7 +3279,7 @@
> if (mddev2 == mddev)
> continue;
> if (mddev2->curr_resync && match_mddev_units(mddev,mddev2)) {
>- printk(KERN_INFO "md: serializing resync, md%d has
>overlapping physical units with md%d!\n", mdidx(mddev), mdidx(mddev2));
>+ printk(KERN_INFO "md: serializing resync, md%d has
>shares one or more physical units with md%d!\n", mdidx(mddev), mdidx(mddev2));
> serialize = 1;
> break;
> }
>-

-- 

Ruth Ivimey-Cook ruthc@sharra.demon.co.uk Technical Author, ARM Ltd ruth.ivimey-cook@arm.com

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:19 EST