Re: [NEW DRIVER] firestream

From: Peter Samuelson (peter@cadcamlab.org)
Date: Thu Nov 23 2000 - 00:40:47 EST

Next message: Mohammad A. Haque: "ext2 filesystem corruptions back from dead? 2.4.0-test11"
Previous message: Andries.Brouwer@cwi.nl: "{PATCH} isofs stuff"
In reply to: Patrick van de Lageweg: "[NEW DRIVER] firestream"
Next in thread: Rogier Wolff: "Re: [NEW DRIVER] firestream"
Reply: Rogier Wolff: "Re: [NEW DRIVER] firestream"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

[Patrick van de Lageweg]
> diff -u -r --new-file linux-2.4.0-test11.clean/drivers/atm/firestream.c linux-2.4.0-test11.fs50+atmrefcount/drivers/atm/firestream.c

Since you are submitting in the form of a source patch, you ought to
include the relevent bits of

  drivers/atm/Makefile
  drivers/atm/Config.in
  Documentation/Configure.help

> +int loopback = 0;
> +int fs_debug = 0;
> +struct fs_dev *fs_boards = NULL;

Aside from the 'static' issue already mentioned, these should be left
uninitialized. ('gcc -fassume-bss-zero' would be nice, but then again
in userspace it rarely matters.)

Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Mohammad A. Haque: "ext2 filesystem corruptions back from dead? 2.4.0-test11"
Previous message: Andries.Brouwer@cwi.nl: "{PATCH} isofs stuff"
In reply to: Patrick van de Lageweg: "[NEW DRIVER] firestream"
Next in thread: Rogier Wolff: "Re: [NEW DRIVER] firestream"
Reply: Rogier Wolff: "Re: [NEW DRIVER] firestream"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:25 EST