Re: plug problem in linux-2.4.0-test11

From: Jens Axboe (axboe@suse.de)
Date: Thu Dec 28 2000 - 08:47:59 EST

Next message: Marcelo Tosatti: "Re: Repeatable Oops in 2.4t13p4ac2"
Previous message: Andries Brouwer: "Re: [Patch] shmmin behaviour back to 2.2 behaviour"
In reply to: Andrea Arcangeli: "Re: plug problem in linux-2.4.0-test11"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Dec 27 2000, Andrea Arcangeli wrote:
> I think right behaviour of the blkdev layer is to BUG() if the driver eats
> requests while the device is plugged.

The device is supposed to know what it's doing. Sure it defeats the
elevators work a bit, but again the driver should know best. Besides, it
doesn't seem worthwhile to go to any lengths detecting this.

But in general I agree, device request_fn should never touch a plugged
queue.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Marcelo Tosatti: "Re: Repeatable Oops in 2.4t13p4ac2"
Previous message: Andries Brouwer: "Re: [Patch] shmmin behaviour back to 2.2 behaviour"
In reply to: Andrea Arcangeli: "Re: plug problem in linux-2.4.0-test11"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Dec 31 2000 - 21:00:11 EST