Re: Where did vm_operations_struct->unmap in 2.4.0 go?

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sun Jan 14 2001 - 15:15:29 EST


On Sun, 14 Jan 2001, David Woodhouse wrote:
>
> But in the case of the CFI probe code and also I believe DRM, we don't
> actually know precisely which feature we're going to require until we've
> done the hardware probe at runtime.

That's ok.

This is what "request_module()" and "kmod" is all about. Once we probe the
hardware, the drievr itself can ask for more drivers.

I completely fail to see the arguments that have been brought up for drm
doing ugly things. The code should simply do

        drm_agp_head_t * head = inter_module_get("drm_agp");

        if (!head) {
                request_module("drm-agp");
                head = inter_module_get("drm_agp");
                if (!head)
                        return -ENOAGP;
        }

and be done with it. THE ABOVE MAKES SENSE. The code says _exactly_ what
the module wants to do: it wants to find the AGP support, and if it cannot
find the AGP support it wants to load them.

The arguments about how the user should load things in some specific order
or whatever are complete crap. All the support is there, and whining about
it is not going to change my opinion in the least.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jan 15 2001 - 21:00:39 EST