Re: [Patch] memparse should return long long

From: Christoph Rohland (cr@sap.com)
Date: Mon Jan 15 2001 - 12:25:06 EST


Hi Randy,

On Mon, 15 Jan 2001, Randy Dunlap wrote:
> Why not (?):

Because I did not need it (always used #G or #M) and did not know the
function. But it's apparently correct to use simple_strtoull.

>> diff -uNr 2.4.0-ac/lib/cmdline.c 2.4.0-ac-memparse/lib/cmdline.c
>> --- 2.4.0-ac/lib/cmdline.c Mon Aug 28 11:42:45 2000
>> +++ 2.4.0-ac-memparse/lib/cmdline.c Mon Jan 15 09:06:14 2001
>> @@ -93,9 +93,9 @@
>> * megabyte, or one gigabyte, respectively.
>> */
>>
>> -unsigned long memparse (char *ptr, char **retptr)
>> +unsigned long long memparse (char *ptr, char **retptr)
>> {
>> - unsigned long ret = simple_strtoul (ptr, retptr, 0);
>> + unsigned long long ret = simple_strtoul (ptr, retptr, 0);
> ! + unsigned long long ret = simple_strtoull (ptr, retptr, 0);
>
> ~Randy

Greetings
                Christoph

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jan 15 2001 - 21:00:41 EST