Re: RAMFS

From: Ingo Oeser (ingo.oeser@informatik.tu-chemnitz.de)
Date: Fri Feb 02 2001 - 12:57:09 EST

Next message: Hans Reiser: "Re: ReiserFS Oops (2.4.1, deterministic, symlink"
Previous message: David Lang: "Re: sendfile+zerocopy: fairly sexy (nothing to do with ECN)"
In reply to: Alan Cox: "RAMFS"
Next in thread: Mike Galbraith: "Re: RAMFS"
Reply: Mike Galbraith: "Re: RAMFS"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Feb 02, 2001 at 03:51:53PM +0000, Alan Cox wrote:
> Does this fix the ramfs problem in -ac ?
>
> --- fs/ramfs/inode.c~ Wed Jan 31 22:02:16 2001
> +++ fs/ramfs/inode.c Fri Feb 2 14:51:47 2001
> @@ -174,7 +174,6 @@
> inode->i_blocks += IBLOCKS_PER_PAGE;
> rsb->free_pages--;
> SetPageDirty(page);
> - UnlockPage(page);
> } else {
> ClearPageUptodate(page);
> ret = 0;
> @@ -264,6 +263,7 @@
>
> if (! ramfs_alloc_page(inode, page))
> return -ENOSPC;
> + UnlockPage(page);
> return 0;
> }

No, so have to unlock it also, if you return -ENOSPC.

So the correct fix seems to be:

--- linux/fs/ramfs/inode.c~ Wed Jan 31 22:02:16 2001
+++ linux/fs/ramfs/inode.c Fri Feb 2 14:51:47 2001
@@ -174,7 +174,6 @@
                 inode->i_blocks += IBLOCKS_PER_PAGE;
                 rsb->free_pages--;
                 SetPageDirty(page);
- UnlockPage(page);
         } else {
                 ClearPageUptodate(page);
                 ret = 0;
@@ -264,6 +263,9 @@

- if (! ramfs_alloc_page(inode, page))
+ if (! ramfs_alloc_page(inode, page)) {
+ UnlockPage(page);
                 return -ENOSPC;
+ }
+ UnlockPage(page);
         return 0;
}

This currently works for me (but using 2.4.0 + dwg-ramfs.patch + this patch)

Regards

Ingo Oeser

-- 
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<       come and join the fun       >>>>>>>>>>>>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Hans Reiser: "Re: ReiserFS Oops (2.4.1, deterministic, symlink"
Previous message: David Lang: "Re: sendfile+zerocopy: fairly sexy (nothing to do with ECN)"
In reply to: Alan Cox: "RAMFS"
Next in thread: Mike Galbraith: "Re: RAMFS"
Reply: Mike Galbraith: "Re: RAMFS"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Feb 07 2001 - 21:00:15 EST