Re: [patch] patch-2.4.1-irda4 (irlap speed)

From: Pavel Machek (pavel@suse.cz)
Date: Sun Feb 11 2001 - 18:23:54 EST

Next message: Tobias Ringstrom: "Re: making forward at vger.rutgers.org? [was Re: maestro3 patch, resent]"
Previous message: Pavel Machek: "making forward at vger.rutgers.org? [was Re: maestro3 patch, resent]"
In reply to: Dag Brattli: "[patch] patch-2.4.1-irda4 (irlap speed)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi!

> --- linux-2.4.1-patch/include/net/irda/irda_device.h Tue Jan 30 08:24:54 2001
> +++ linux-2.4.1-irda-patch/include/net/irda/irda_device.h Thu Feb 8 22:34:07 2001
> @@ -218,29 +218,54 @@ extern inline __u16 irda_get_mtt(struct
> #endif
>
> /*
> - * Function irda_get_speed (skb)
> + * Function irda_get_next_speed (skb)
> *
> - * Extact the speed this frame should be sent out with from the skb
> + * Extract the speed that should be set *after* this frame from the skb
> *
> + * Note : return -1 for user space frames
> */
> -#define irda_get_speed(skb) ( \
> +#define irda_get_next_speed(skb) ( \
> (((struct irda_skb_cb*) skb->cb)->magic == LAP_MAGIC) ? \
> - ((struct irda_skb_cb *)(skb->cb))->speed : 9600 \
> + ((struct irda_skb_cb *)(skb->cb))->next_speed : -1 \
> )
>
> #if 0
> -extern inline __u32 irda_get_speed(struct sk_buff *skb)
> +extern inline __u32 irda_get_next_speed(struct sk_buff *skb)

This is kernel code, you do not have to use __u32 here. Use u32
instead (it looks much better).
Pavel

-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Tobias Ringstrom: "Re: making forward at vger.rutgers.org? [was Re: maestro3 patch, resent]"
Previous message: Pavel Machek: "making forward at vger.rutgers.org? [was Re: maestro3 patch, resent]"
In reply to: Dag Brattli: "[patch] patch-2.4.1-irda4 (irlap speed)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Feb 15 2001 - 21:00:18 EST