flush_page_to_ram() question in kernel/ptrace.c

From: Manfred Spraul (manfred@colorfullife.com)
Date: Thu Mar 08 2001 - 15:00:40 EST

>From linux/kernel/ptrace.c, access_one_page():

> flush_cache_page(vma, addr);
>
> if (write) {
> maddr = kmap(page);
> memcpy(maddr + (addr & ~PAGE_MASK), buf, len);
> flush_page_to_ram(page);
> flush_icache_page(vma, page);
> kunmap(page);
> } else {
> maddr = kmap(page);
> memcpy(buf, maddr + (addr & ~PAGE_MASK), len);
> flush_page_to_ram(page);
                  ^^^^^^^^^^^^^^^^^^^^^^
> kunmap(page);
> }

Is this flush required?

The memcpy read from the mapping, it didn't write. 

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Mar 15 2001 - 21:00:08 EST