All,
OK, Helge is of course correct here. I will get a new patch out tonight.
Basically, the ending = -1; needs to be preceded by an else.
(I think so anyway, as I don't have access to that machine right now.)
Hal Duston
hald@sound.net
On Mon, 9 Apr 2001, Helge Deller wrote:
> Hi Hal,
>
> I don't have any ps2esdi devices, but while I was looking at your patch I
> found:
>
> case INT_CMD_COMPLETE:
> @@ -893,13 +879,9 @@
> printk("%s: timeout reading status word\n", DEVICE_NAME);
> outb((int_ret_code & 0xe0) | ATT_EOI, ESDI_ATTN);
> outb(CTRL_ENABLE_INTR, ESDI_CONTROL);
> - if ((++CURRENT->errors) < MAX_RETRIES)
> - do_ps2esdi_request(NULL);
> - else {
> - end_request(FAIL);
> - if (!QUEUE_EMPTY)
> - do_ps2esdi_request(NULL);
> - }
> + if ((++CURRENT->errors) >= MAX_RETRIES)
> + ending = FAIL;
> + ending = -1;
> break;
> }
>
> Just a thought:
> in this if().. clause ending may get the FAIL value, but directly afterwards
> it is set to -1 again....
> You have this two times in your patch.
>
> Greetings,
> Helge.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Apr 15 2001 - 21:00:11 EST