> In its current implementation, scsi_unblock_requests() simply
> clears host_self_blocked in the SCSI host struct. This means
> that either a transaction must complete or a new transaction
Suppose the queue is unblocked from inside the functions called to process
the request. In that situation the old code is correct and your code might
introduce other problems
> unblocks. scsi_queue_next_request() verifies all other state
> to ensure queuing new transactions is safe prior to proceeding.
Including recursion ?
The patch seems right apart from checking these details out further.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Apr 15 2001 - 21:00:13 EST