Re: Fix for Donald Becker's DP83815 network driver (v1.07)

From: Roberto Nibali (ratz@tac.ch)
Date: Tue Apr 17 2001 - 11:16:48 EST

Steve Hill wrote:
>
> The attached patch fixes the following problems with the DP83815 driver
> (natsemi.c):
>
> 1. When compiled into the kernel, the cards would be registered multiple
> times.

I assume this code fragment fixes this:

+ static int done = 0;

+
+ if (done) return -ENODEV;
        if (pci_drv_register(&natsemi_drv_id, dev) < 0)
                return -ENODEV;
+ done = 1;

My 2 questions are:
Is this an acceptable fix for Donald? Because if so, I'd like to submit it
for the starfire quardboard driver.

--- starfire.c-old Tue Apr 17 18:11:07 2001
+++ starfire.c Tue Apr 17 18:12:37 2001
@@ -378,8 +378,12 @@
 #ifndef MODULE
 int starfire_probe(struct net_device *dev)
 {
+ static int done = 0;
+
+ if (done) return -ENODEV;
         if (pci_drv_register(&starfire_drv_id, dev) < 0)
                 return -ENODEV;
+ done = 1;
         printk(KERN_INFO "%s" KERN_INFO "%s", version1, version2);
         return 0;
 }

Is there no implication with PCI latencies if multiple such cards
are loaded? I'm still having problems initializing more then 4
Quadboards.

Regards,
Roberto Nibali, ratz 

-- 
mailto: `echo NrOatSz@tPacA.cMh | sed 's/[NOSPAM]//g'`
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:23 EST