Re: [PATCH] generic rw_semaphores, compile warnings patch

From: Ivan Kokshaysky (ink@jurassic.park.msu.ru)
Date: Fri Apr 20 2001 - 07:04:43 EST


On Fri, Apr 20, 2001 at 08:50:38AM +0100, David Howells wrote:
> There's also a missing "struct rw_semaphore;" declaration in linux/rwsem.h. It
> needs to go in the gap below "#include <linux/wait.h>". Otherwise the
> declarations for the contention handling functions will give warnings about
> the struct being declared in the parameter list.

Also on alpha __u16 is undeclared in rwsem.c, and old rwsem code wasn't
cleaned up properly.

Ivan.

--- 2.4.4p5/include/linux/rwsem-spinlock.h Fri Apr 20 14:06:50 2001
+++ linux/include/linux/rwsem-spinlock.h Fri Apr 20 15:37:28 2001
@@ -14,6 +14,8 @@
 
 #ifdef __KERNEL__
 
+#include <linux/types.h>
+
 /*
  * the semaphore definition
  */
--- 2.4.4p5/include/asm-alpha/semaphore.h Fri Apr 20 13:53:28 2001
+++ linux/include/asm-alpha/semaphore.h Fri Apr 20 15:37:28 2001
@@ -225,5 +225,3 @@ extern inline void up(struct semaphore *
 #endif
 
 #endif
-
-#endif
--- 2.4.4p5/arch/alpha/kernel/alpha_ksyms.c Fri Apr 20 13:52:56 2001
+++ linux/arch/alpha/kernel/alpha_ksyms.c Fri Apr 20 14:01:36 2001
@@ -173,9 +173,6 @@ EXPORT_SYMBOL(down);
 EXPORT_SYMBOL(down_interruptible);
 EXPORT_SYMBOL(down_trylock);
 EXPORT_SYMBOL(up);
-EXPORT_SYMBOL(__down_read_failed);
-EXPORT_SYMBOL(__down_write_failed);
-EXPORT_SYMBOL(__rwsem_wake);
 EXPORT_SYMBOL(down_read);
 EXPORT_SYMBOL(down_write);
 EXPORT_SYMBOL(up_read);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:36 EST