Re: rwsem.o listed twice as export-objs

From: Ingo Oeser (ingo.oeser@informatik.tu-chemnitz.de)
Date: Sat Apr 21 2001 - 13:18:15 EST


On Sat, Apr 21, 2001 at 06:06:34PM +0200, Christoph Hellwig wrote:
> In article <20010420215330.N682@nightmaster.csn.tu-chemnitz.de> you wrote:
> > please remove rwsem.o from the list of exported objects, if it is
> > not used.
>
> No! The whole point of 'export-objs' is to _always_ list the objects there
> to make the makefiles smaller and cleaner.

Ok, so this patch is better?

--- linux/lib/Makefile.orig Sat Apr 21 20:15:00 2001
+++ linux/lib/Makefile Sat Apr 21 20:14:37 2001
@@ -8,12 +8,11 @@

 L_TARGET := lib.a

 export-objs := cmdline.o rwsem.o

 obj-y := errno.o ctype.o string.o vsprintf.o brlock.o cmdline.o bust_spinlocks.o

 ifneq ($(CONFIG_RWSEM_GENERIC_SPINLOCK)$(CONFIG_RWSEM_XCHGADD_ALGORITHM),nn)
-export-objs += rwsem.o
 obj-y += rwsem.o
 endif

Because any of the solutions should be applied, because rwsem.o
is listed twice currently, which gives a warning at compile time.

Regards

Ingo Oeser

-- 
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<     been there and had much fun   >>>>>>>>>>>>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:40 EST