> 1. What are the char* -> char array conversions of "version" strings for ?
char*="blah" generates a char pointer variable, pointing to the constant
string "blah". char[]="blah" eliminates the char pointer variable, so
the resulting code is [slightly] smaller.
> 3. The following patch
> - marks most of the version strings __initdata/__devinitdata (necessary
> removing of "const" from their declaration), removes unnecessary format
> strings from their printk()s, moves to __init/adds log level markers to
> them (KERN_*)
> - adds/fixes some other __init code,
> - removes some unnecessary zero initializers
> from most of the network drivers.
looks ok at a glance, I will probably apply it after reviewing further.
note a further cleanup is to look at each driver, and make sure (a) it
-always- printk's version if -DMODULE, and (b) if only printk's version
if hardware is found, if not -DMODULE. You can look at pci net drivers
in 2.4.4-pre6 for an example of how I did this.
--
Jeff Garzik | The difference between America and England is that
Building 1024 | the English think 100 miles is a long distance and
MandrakeSoft | the Americans think 100 years is a long time.
| (random fortune)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:46 EST