Re: unsigned long ioremap()?

From: Abramo Bagnara (abramo@alsa-project.org)
Date: Thu May 03 2001 - 04:57:40 EST

David Woodhouse wrote:
>
> abramo@alsa-project.org said:
> > The problem I see is that with the former solution nothing prevents
> > from to do:
>
> > regs->reg2 = 13;
>
> > That's indeed the reason to change ioremap prototype for 2.5.
>
> An alternative is to add an fixed offset to the cookie before returning it,
> and subtract it again in {read,write}[bwl].

You understand that in this way you change a compile time warning in a
runtime error (conditioned to path reaching, not easy to interpret,
etc.)

IMO this is a far less effective debugging strategy. 

-- 
Abramo Bagnara                       mailto:abramo@alsa-project.org

Opera Unica                          Phone: +39.546.656023
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy

ALSA project               http://www.alsa-project.org
It sounds good!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon May 07 2001 - 21:00:16 EST